From c3a06ad20365a89ce3209f33fa33c9ae7e98af67 Mon Sep 17 00:00:00 2001
From: stellahsr <stellahsr@126.com>
Date: Tue, 12 Dec 2023 10:10:07 +0800
Subject: [PATCH] =?UTF-8?q?=E6=9B=B4=E6=96=B0reflection=EF=BC=8C=E5=88=86?=
 =?UTF-8?q?=E5=BC=80=E5=8E=86=E5=8F=B2code=E5=92=8C=E5=B7=B2=E6=9C=89?=
 =?UTF-8?q?=E8=BF=90=E8=A1=8C=E7=BB=93=E6=9E=9C?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 metagpt/actions/debug_code.py | 39 ++++++++++++++++++++++++-----------
 1 file changed, 27 insertions(+), 12 deletions(-)

diff --git a/metagpt/actions/debug_code.py b/metagpt/actions/debug_code.py
index 3d460fa40..9efe93efc 100644
--- a/metagpt/actions/debug_code.py
+++ b/metagpt/actions/debug_code.py
@@ -41,6 +41,12 @@ REFLECTION_PROMPT = """
                        {debug_example}
                        [requirement]
                        {goal}
+                       [finished code]
+                       finished code are executable, and you should based on the code to continue your current code debug
+                       {finished_code}
+                       
+                       try to reuse the code here to understand the coding task.
+                       
                        [previous impl]
                        {code}
                        [runtime Error]
@@ -65,47 +71,56 @@ class DebugCode(BaseWriteAnalysisCode):
     name: str = "debugcode"
     context: Optional[str] = None
     llm: None
-
+    
     def __init__(self, **kwargs: Any):
         super().__init__(**kwargs)
-
-    async def run_reflection(self, plan, code, runtime_result) -> str:
+    
+    async def run_reflection(self, goal, finished_code, finished_code_result, code, runtime_result) -> str:
         info = []
+        finished_code_and_result = finished_code + "\n [finished results]\n\n" + finished_code_result
         reflection_prompt = REFLECTION_PROMPT.format(debug_example=DEBUG_REFLECTION_EXAMPLE,
-                                                     goal=plan.goal,
+                                                     goal=goal,
+                                                     finished_code=finished_code_and_result,
                                                      code=code,
                                                      runtime_result=runtime_result
                                                      )
         system_prompt = "You are an AI Python assistant. You will be given your previous implementation of a function, runtime error results, and a hint to change the implementation appropriately. Write your full implementation "
         info.append(Message(role="system", content=system_prompt))
         info.append(Message(role="assistant", content=reflection_prompt))
-
+        
         msg = messages_to_str(info)
         resp = await self.llm.aask(msg=msg)
         logger.info(f"reflection is {resp}")
         return resp
-
-    async def rewrite_code(self, reflection: str = "") -> str:
+    
+    async def rewrite_code(self, reflection: str = "", code_context: str = "") -> str:
         """
         根据reflection重写代码
         """
         info = []
-        info.append(Message(role="assistant", content=f"[reflection]: \n {reflection}"))
+        info.append(Message(role="assistant", content=f"[code context]:{code_context}"
+                                                      f"finished code are executable, and you should based on the code to continue your current code debug and improvement"
+                                                      f"[reflection]: \n {reflection}"))
         info.append(Message(role="user", content=f"[improved impl]:\n Return in Python block"))
         msg = messages_to_str(info)
         resp = await self.llm.aask(msg=msg)
         logger.info(f"improve code is {resp}")
         improv_code = CodeParser.parse_code(block=None, text=resp)
         return improv_code
-
+    
     async def run(self,
-                  plan: Plan = None,
+                  plan: str = "",
+                  finished_code: str = "",
+                  finished_code_result: str = "",
                   code: str = "",
                   runtime_result: str = "") -> str:
         """
         根据当前运行代码和报错信息进行reflection和纠错
         """
-        reflection = await self.run_reflection(plan, code, runtime_result)
+        reflection = await self.run_reflection(plan, finished_code=finished_code,
+                                               finished_code_result=finished_code_result,
+                                               code=code,
+                                               runtime_result=runtime_result)
         # 根据reflection结果重写代码
-        improv_code = await self.rewrite_code(reflection)
+        improv_code = await self.rewrite_code(reflection, code_context=finished_code)
         return improv_code