From 9745dd12f6bdb27bc5bbc16401605c3f9bbe688c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=8E=98=E6=9D=83=20=E9=A9=AC?= <mashenquan@fuzhi.ai>
Date: Tue, 28 Nov 2023 16:28:53 +0800
Subject: [PATCH] feat: fix memory.add

---
 metagpt/roles/role.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/metagpt/roles/role.py b/metagpt/roles/role.py
index dbf800c03..62c8b7708 100644
--- a/metagpt/roles/role.py
+++ b/metagpt/roles/role.py
@@ -226,9 +226,9 @@ class Role:
         # Read unprocessed messages from the msg buffer.
         news = self._rc.msg_buffer.pop_all()
         # Store the read messages in your own memory to prevent duplicate processing.
+        old_messages = self._rc.memory.get()
         self._rc.memory.add_batch(news)
         # Filter out messages of interest.
-        old_messages = self._rc.memory.get()
         self._rc.news = [n for n in news if n.cause_by in self._rc.watch and n not in old_messages]
 
         # Design Rules: