From 6be9e10175197e7f73f93e27645532eac138ed89 Mon Sep 17 00:00:00 2001 From: seehi <6580@pm.me> Date: Wed, 14 Aug 2024 16:07:24 +0800 Subject: [PATCH] update comment --- metagpt/schema.py | 2 +- metagpt/tools/libs/browser.py | 2 +- metagpt/utils/common.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/metagpt/schema.py b/metagpt/schema.py index ad8c8f1d7..8ef7dd0bb 100644 --- a/metagpt/schema.py +++ b/metagpt/schema.py @@ -121,7 +121,7 @@ class SerializationMixin(BaseModel, extra="forbid"): if class_type is None: # TODO could try dynamic import - raise TypeError("Trying to instantiate {class_full_name}, which has not yet been defined!") + raise TypeError(f"Trying to instantiate {class_full_name}, which has not yet been defined!") return class_type(**value) diff --git a/metagpt/tools/libs/browser.py b/metagpt/tools/libs/browser.py index 3efddd2e8..bba7fa5a8 100644 --- a/metagpt/tools/libs/browser.py +++ b/metagpt/tools/libs/browser.py @@ -75,7 +75,7 @@ class Browser(BaseModel): page: Optional[Page] = None accessibility_tree: list = Field(default_factory=list) headless: bool = True - proxy: Optional[str] = Field(default_factory=get_proxy_from_env) + proxy: Optional[dict] = Field(default_factory=get_proxy_from_env) is_empty_page: bool = True reporter: BrowserReporter = Field(default_factory=BrowserReporter) diff --git a/metagpt/utils/common.py b/metagpt/utils/common.py index 65bfa480d..1ba6f8239 100644 --- a/metagpt/utils/common.py +++ b/metagpt/utils/common.py @@ -566,7 +566,7 @@ def general_after_log(i: "loguru.Logger", sec_format: str = "%0.3f") -> Callable return log_it -def read_json_file(json_file: str, encoding="utf-8") -> list[Any]: +def read_json_file(json_file: str, encoding: str = "utf-8") -> list[Any]: if not Path(json_file).exists(): raise FileNotFoundError(f"json_file: {json_file} not exist, return []") @@ -595,7 +595,7 @@ def handle_unknown_serialization(x: Any) -> str: return f"" -def write_json_file(json_file: str, data: Any, encoding: str = None, indent: int = 4, use_fallback: bool = False): +def write_json_file(json_file: str, data: Any, encoding: str = "utf-8", indent: int = 4, use_fallback: bool = False): folder_path = Path(json_file).parent if not folder_path.exists(): folder_path.mkdir(parents=True, exist_ok=True)