From 2bc88cd71b45a6bcdc6e9c287f05e722f69b44f0 Mon Sep 17 00:00:00 2001
From: mannaandpoem <1580466765@qq.com>
Date: Thu, 18 Jan 2024 10:15:36 +0800
Subject: [PATCH] update function of save code_guideline file

---
 metagpt/actions/write_code_guideline_an.py | 15 +++++----------
 metagpt/roles/engineer.py                  |  7 +++----
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/metagpt/actions/write_code_guideline_an.py b/metagpt/actions/write_code_guideline_an.py
index ff59ee7d6..28af592c0 100644
--- a/metagpt/actions/write_code_guideline_an.py
+++ b/metagpt/actions/write_code_guideline_an.py
@@ -187,20 +187,15 @@ class WriteCodeGuideline(Action):
         return await WRITE_CODE_GUIDELINE_NODE.fill(context=context, llm=self.llm, schema="json")
 
     @staticmethod
-    async def save(guideline):
-        await WriteCodeGuideline.save_json(guideline)
-        await WriteCodeGuideline.save_md(guideline)
-
-    @staticmethod
-    async def save_json(guideline):
-        filename = "code_guideline.json"
+    async def save_json(guideline, filename="code_guideline.json"):
         await CONFIG.git_repo.new_file_repository(CODE_GUIDELINE_FILE_REPO).save(
             filename=filename, content=str(guideline)
         )
 
     @staticmethod
-    async def save_md(guideline):
-        filename = "code_guideline.md"
+    async def save_md(guideline, filename="code_guideline.md"):
+        guideline_md = dict_to_markdown(guideline)
         await CONFIG.git_repo.new_file_repository(CODE_GUIDELINE_PDF_FILE_REPO).save(
-            filename=filename, content=dict_to_markdown(guideline)
+            filename=filename, content=guideline_md
         )
+        return guideline_md
diff --git a/metagpt/roles/engineer.py b/metagpt/roles/engineer.py
index bb0a2e857..d767b1ebf 100644
--- a/metagpt/roles/engineer.py
+++ b/metagpt/roles/engineer.py
@@ -26,7 +26,6 @@ from pathlib import Path
 from typing import Set
 
 from metagpt.actions import Action, WriteCode, WriteCodeReview, WriteTasks
-from metagpt.actions.action_node import dict_to_markdown
 from metagpt.actions.fix_bug import FixBug
 from metagpt.actions.summarize_code import SummarizeCode
 from metagpt.actions.write_code_guideline_an import (
@@ -367,10 +366,10 @@ class Engineer(Role):
         )
         node = await WriteCodeGuideline().run(context=context)
         guideline = node.instruct_content.model_dump()
-        await WriteCodeGuideline.save(guideline)
-        guideline = dict_to_markdown(guideline)
+        await WriteCodeGuideline.save_json(guideline)
+        guideline_md = await WriteCodeGuideline.save_md(guideline)
 
-        return Document(root_path=CODE_GUIDELINE_PDF_FILE_REPO, filename="code_guideline.md", content=guideline)
+        return Document(root_path=CODE_GUIDELINE_PDF_FILE_REPO, filename="code_guideline.md", content=guideline_md)
 
     @staticmethod
     async def get_old_codes() -> str: