From ef3bfa46764561a2846f529371bf4199abf32780 Mon Sep 17 00:00:00 2001
From: Max Zwiessele <ibinbei@gmail.com>
Date: Thu, 6 Feb 2014 12:00:43 +0000
Subject: [PATCH] highest parent fix

---
 GPy/core/parameterization/param.py         |  2 ++
 GPy/core/parameterization/parameterized.py | 17 +++++++++++------
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/GPy/core/parameterization/param.py b/GPy/core/parameterization/param.py
index 64f0a36d..462210dc 100644
--- a/GPy/core/parameterization/param.py
+++ b/GPy/core/parameterization/param.py
@@ -153,6 +153,8 @@ class Param(ObservableArray, Constrainable):
     @property
     def _parameters_(self):
         return []
+    def _connect_highest_parent(self, highest_parent):
+        self._highest_parent_ = highest_parent
     def _collect_gradient(self, target):
         target[:] = self.gradient.flat
     #===========================================================================
diff --git a/GPy/core/parameterization/parameterized.py b/GPy/core/parameterization/parameterized.py
index 7011f33d..6feed470 100644
--- a/GPy/core/parameterization/parameterized.py
+++ b/GPy/core/parameterization/parameterized.py
@@ -217,13 +217,9 @@ class Parameterized(Constrainable, Pickleable, Observable):
         self._param_slices_ = []
         for p in self._parameters_:
             p._direct_parent_ = self
-            p._highest_parent_ = self
             p._parent_index_ = i
+            p._connect_highest_parent(self)
             i += 1
-            for pi in p.flattened_parameters:
-                pi._highest_parent_ = self
-            for pi in p._parameters_:
-                pi._highest_parent_ = self
             not_unique = []
             sizes.append(p.size+sizes[-1])
             self._param_slices_.append(slice(sizes[-2], sizes[-1]))
@@ -237,7 +233,16 @@ class Parameterized(Constrainable, Pickleable, Observable):
             elif not (pname in not_unique):
                 self.__dict__[pname] = p
                 self._added_names_.add(pname)
-            
+        
+    def _connect_highest_parent(self, highest_parent):
+        self._highest_parent_ = highest_parent
+        if not hasattr(self, "_parameters_") or len(self._parameters_) < 1:
+            # no parameters for this class
+            return
+        for p in self._parameters_:
+            p._highest_parent_ = highest_parent
+            p._connect_highest_parent(highest_parent)
+        
     #===========================================================================
     # Pickling operations
     #===========================================================================