From b58c8a0ab94e43a153cc9c8a732ef198fdbc197e Mon Sep 17 00:00:00 2001 From: Akash Kumar Dhaka Date: Sat, 17 Jun 2017 19:01:04 +0300 Subject: [PATCH] bug fix to prevent infinite loop because of incorrect stopping condition --- .../latent_function_inference/expectation_propagation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GPy/inference/latent_function_inference/expectation_propagation.py b/GPy/inference/latent_function_inference/expectation_propagation.py index c70f8496..194ee6d6 100644 --- a/GPy/inference/latent_function_inference/expectation_propagation.py +++ b/GPy/inference/latent_function_inference/expectation_propagation.py @@ -150,7 +150,7 @@ class EPBase(object): def _stop_criteria(self, ga_approx): tau_diff = np.mean(np.square(ga_approx.tau-self.ga_approx_old.tau)) v_diff = np.mean(np.square(ga_approx.v-self.ga_approx_old.v)) - return ((tau_diff > self.epsilon) or (v_diff > self.epsilon)) + return ((tau_diff < self.epsilon) and (v_diff < self.epsilon)) def __setstate__(self, state): super(EPBase, self).__setstate__(state[0])