From 988bad88a31434f5821a2b40e3f03e49425ecde2 Mon Sep 17 00:00:00 2001 From: Max Zwiessele Date: Wed, 5 Mar 2014 12:50:46 +0000 Subject: [PATCH] numerical global diff in gradcheck --- GPy/core/model.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GPy/core/model.py b/GPy/core/model.py index 343d5f08..e7924b2b 100644 --- a/GPy/core/model.py +++ b/GPy/core/model.py @@ -300,9 +300,9 @@ class Model(Parameterized): gradient = gradient[transformed_index] global_ratio = (f1 - f2) / (2 * np.dot(dx, np.where(gradient == 0, 1e-32, gradient))) - num_grad =(np.abs((f1-f2)/-(2*dx)*np.where(gradient == 0, 1e-32, gradient))).mean() + gloabl_diff = (f1 - f2) - (2 * np.dot(dx, np.where(gradient == 0, 1e-32, gradient))) - return (np.abs(1. - global_ratio) < tolerance) or (num_grad < tolerance) + return (np.abs(1. - global_ratio) < tolerance) or (np.abs(gloabl_diff) < tolerance) else: # check the gradient of each parameter individually, and do some pretty printing try: