From 9fdea8ca377f545166ad9006f05a479bd0ddb7fd Mon Sep 17 00:00:00 2001 From: marecabo <23156476+marecabo@users.noreply.github.com> Date: Mon, 5 Aug 2019 10:26:15 +0200 Subject: [PATCH 1/2] fix plotly default marker size property type --- GPy/plotting/plotly_dep/defaults.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GPy/plotting/plotly_dep/defaults.py b/GPy/plotting/plotly_dep/defaults.py index 121e0b37..c5b2540c 100644 --- a/GPy/plotting/plotly_dep/defaults.py +++ b/GPy/plotting/plotly_dep/defaults.py @@ -44,7 +44,7 @@ it gives back an empty default, when defaults are not defined. # Data plots: data_1d = dict(marker_kwargs=dict(), marker='x', color='black') -data_2d = dict(marker='o', cmap='Hot', marker_kwargs=dict(opacity=1., size='5', line=Line(width=.5, color='black'))) +data_2d = dict(marker='o', cmap='Hot', marker_kwargs=dict(opacity=1., size=5, line=Line(width=.5, color='black'))) inducing_1d = dict(color=Tango.colorsHex['darkRed']) inducing_2d = dict(marker_kwargs=dict(size='5', opacity=.7, line=Line(width=.5, color='black')), opacity=.7, color='white', marker='star-triangle-up') inducing_3d = dict(marker_kwargs=dict(symbol='diamond', size='5', opacity=.7, line=Line(width=.1, color='black')), color='#F5F5F5') From e0d214446c7e4cceac9d6505e8097dd293b42efc Mon Sep 17 00:00:00 2001 From: marecabo <23156476+marecabo@users.noreply.github.com> Date: Mon, 5 Aug 2019 10:26:35 +0200 Subject: [PATCH 2/2] fix plotly default marker symbol dict --- GPy/plotting/plotly_dep/plot_definitions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GPy/plotting/plotly_dep/plot_definitions.py b/GPy/plotting/plotly_dep/plot_definitions.py index 9b659551..9572508d 100644 --- a/GPy/plotting/plotly_dep/plot_definitions.py +++ b/GPy/plotting/plotly_dep/plot_definitions.py @@ -39,7 +39,7 @@ from plotly.graph_objs import Scatter, Scatter3d, Line,\ from plotly.exceptions import PlotlyDictKeyError SYMBOL_MAP = { - 'o': 'dot', + 'o': 'circle-dot', 'v': 'triangle-down', '^': 'triangle-up', '<': 'triangle-left', @@ -47,7 +47,7 @@ SYMBOL_MAP = { 's': 'square', '+': 'cross', 'x': 'x', - '*': 'x', # no star yet in plotly!! + '*': 'star', 'D': 'diamond', 'd': 'diamond', }