From 6678bca011dff22516db7b463c655860bf49cb9b Mon Sep 17 00:00:00 2001 From: Alan Saul Date: Wed, 23 Oct 2013 13:28:08 +0100 Subject: [PATCH] Fixed bug in gradient checker where it worked differently given a integer parameter to a float --- GPy/models/gradient_checker.py | 2 +- GPy/testing/likelihoods_tests.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/GPy/models/gradient_checker.py b/GPy/models/gradient_checker.py index face9589..64b8b2fb 100644 --- a/GPy/models/gradient_checker.py +++ b/GPy/models/gradient_checker.py @@ -75,7 +75,7 @@ class GradientChecker(Model): self.names = names self.shapes = [get_shape(x0)] for name, xi in zip(self.names, at_least_one_element(x0)): - self.__setattr__(name, xi) + self.__setattr__(name, numpy.float_(xi)) # self._param_names = [] # for name, shape in zip(self.names, self.shapes): # self._param_names.extend(map(lambda nameshape: ('_'.join(nameshape)).strip('_'), itertools.izip(itertools.repeat(name), itertools.imap(lambda t: '_'.join(map(str, t)), itertools.product(*map(lambda xi: range(xi), shape)))))) diff --git a/GPy/testing/likelihoods_tests.py b/GPy/testing/likelihoods_tests.py index 449f3e90..9a3dfd16 100644 --- a/GPy/testing/likelihoods_tests.py +++ b/GPy/testing/likelihoods_tests.py @@ -321,6 +321,7 @@ class TestNoiseModels(object): def t_dlogpdf_dparams(self, model, Y, f, params, param_constraints): print "\n{}".format(inspect.stack()[0][3]) print model + print param_constraints assert ( dparam_checkgrad(model.logpdf, model.dlogpdf_dtheta, params, args=(f, Y), constraints=param_constraints, @@ -331,6 +332,7 @@ class TestNoiseModels(object): def t_dlogpdf_df_dparams(self, model, Y, f, params, param_constraints): print "\n{}".format(inspect.stack()[0][3]) print model + print param_constraints assert ( dparam_checkgrad(model.dlogpdf_df, model.dlogpdf_df_dtheta, params, args=(f, Y), constraints=param_constraints, @@ -341,6 +343,7 @@ class TestNoiseModels(object): def t_d2logpdf2_df2_dparams(self, model, Y, f, params, param_constraints): print "\n{}".format(inspect.stack()[0][3]) print model + #print param_constraints assert ( dparam_checkgrad(model.d2logpdf_df2, model.d2logpdf_df2_dtheta, params, args=(f, Y), constraints=param_constraints,