From 2da309aab88162cc8d219e8ad746cf7d3944fd87 Mon Sep 17 00:00:00 2001 From: Ricardo Date: Wed, 5 Jun 2013 18:11:08 +0100 Subject: [PATCH] link_function class renamed as LinkFunction --- GPy/likelihoods/likelihood_functions.py | 6 +++--- GPy/likelihoods/link_functions.py | 11 +++++------ GPy/models/fitc_classification.py | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/GPy/likelihoods/likelihood_functions.py b/GPy/likelihoods/likelihood_functions.py index c801b9a9..7b9b8982 100644 --- a/GPy/likelihoods/likelihood_functions.py +++ b/GPy/likelihoods/likelihood_functions.py @@ -21,7 +21,7 @@ class LikelihoodFunction(object): if link == self._analytical: self.moments_match = self._moments_match_analytical else: - assert isinstance(link,link_functions.link_function) + assert isinstance(link,link_functions.LinkFunction) self.link = link self.moments_match = self._moments_match_numerical @@ -79,7 +79,7 @@ class Binomial(LikelihoodFunction): $$ """ def __init__(self,link=None): - self._analytical = link_functions.probit + self._analytical = link_functions.Probit if not link: link = self._analytical super(Binomial, self).__init__(link) @@ -146,7 +146,7 @@ class Poisson(LikelihoodFunction): def __init__(self,link=None): self._analytical = None if not link: - link = link_functions.log() + link = link_functions.Log() super(Poisson, self).__init__(link) def _distribution(self,gp,obs): diff --git a/GPy/likelihoods/link_functions.py b/GPy/likelihoods/link_functions.py index f3b48d21..cd5ae0c5 100644 --- a/GPy/likelihoods/link_functions.py +++ b/GPy/likelihoods/link_functions.py @@ -9,7 +9,7 @@ import pylab as pb from ..util.plot import gpplot from ..util.univariate_Gaussian import std_norm_pdf,std_norm_cdf -class link_function(object): +class LinkFunction(object): """ Link function class for doing non-Gaussian likelihoods approximation @@ -19,7 +19,7 @@ class link_function(object): def __init__(self): pass -class identity(link_function): +class Identity(LinkFunction): def transf(self,mu): return mu @@ -29,7 +29,7 @@ class identity(link_function): def log_inv_transf(self,f): return np.log(f) -class log(link_function): +class Log(LinkFunction): def transf(self,mu): return np.log(mu) @@ -40,7 +40,7 @@ class log(link_function): def log_inv_transf(self,f): return f -class log_ex_1(link_function): +class Log_ex_1(LinkFunction): def transf(self,mu): return np.log(np.exp(mu) - 1) @@ -50,11 +50,10 @@ class log_ex_1(link_function): def log_inv_tranf(self,f): return np.log(np.log(np.exp(f)+1)) -class probit(link_function): +class Probit(LinkFunction): def inv_transf(self,f): return std_norm_cdf(f) def log_inv_transf(self,f): return np.log(std_norm_cdf(f)) - diff --git a/GPy/models/fitc_classification.py b/GPy/models/fitc_classification.py index e2c48b69..65178c8c 100644 --- a/GPy/models/fitc_classification.py +++ b/GPy/models/fitc_classification.py @@ -16,7 +16,7 @@ class FITCClassification(FITC): :param X: input observations :param Y: observed values - :param likelihood: a GPy likelihood, defaults to Binomial with probit link_function + :param likelihood: a GPy likelihood, defaults to Binomial with probit link function :param kernel: a GPy kernel, defaults to rbf+white :param normalize_X: whether to normalize the input data before computing (predictions will be in original scales) :type normalize_X: False|True